Skip to content

tools: use PrintCaughtException in the snapshot builder #38745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

tools: use PrintCaughtException in the snapshot builder #38745

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90fb545
tools: use PrintCaughtException in the snapshot builder
joyeecheung May 20, 2021
f7d5540
fixup! tools: use PrintCaughtException in the snapshot builder
joyeecheung May 20, 2021
ce5b473
fixup! fixup! tools: use PrintCaughtException in the snapshot builder
joyeecheung May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! tools: use PrintCaughtException in the snapshot builder
  • Loading branch information
@joyeecheung
joyeecheung committed May 21, 2021
commit ce5b473613b2d1b12a7328f35ea5340793e6823f
2 changes: 0 additions & 2 deletions tools/snapshot/snapshot_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ using v8::Context;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
using v8::SnapshotCreator;
using v8::StartupData;
using v8::String;
using v8::TryCatch;
using v8::Value;

Expand Down