Skip to content

src: use HandleScope in StreamReq::Done() #38720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 2 commits into from
Closed

src: use HandleScope in StreamReq::Done() #38720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8787d00
src: use HandleScope in StreamReq::Done()
RaisinTen May 17, 2021
d89dbd1
Apply suggestions from code review
RaisinTen May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Qingyu Deng <i@ayase-lab.com>
  • Loading branch information
@RaisinTen @Ayase-252
RaisinTen and Ayase-252 authored May 18, 2021
commit d89dbd1303e526129a4a94e6c03fd8f919c6a976
2 changes: 1 addition & 1 deletion test/parallel/test-https-agent-unref-socket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if (!common.hasCrypto)

const https = require('https');

const request = https.get('https://www.google.com');
const request = https.get('https://example.com');

request.on('socket', (socket) => {
socket.unref();
Expand Down