Skip to content

path: inline conditions #38613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
Closed

path: inline conditions #38613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
path: inline conditions 
This condition can be inlined in the first `if` statement since if the `path`'s length is 0, it'll be a empty string so we can return that as there's no need for an extra `if` statement.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva authored May 9, 2021
commit dee7116b2af0a8b165135b30f382ce23ce72548c
6 changes: 1 addition & 5 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,13 +617,9 @@ const win32 = {
*/
toNamespacedPath(path) {
// Note: this will *probably* throw somewhere.
if (typeof path !== 'string')
if (typeof path !== 'string' || path.length === 0)
return path;

if (path.length === 0) {
return '';
}

const resolvedPath = win32.resolve(path);

if (resolvedPath.length <= 2)
Expand Down