Skip to content

src,lib,buffer: improve atob / btoa performance #38433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 10 commits into from
Closed

src,lib,buffer: improve atob / btoa performance #38433

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3f184d
src,lib,buffer: improve atob / btoa performance
XadillaX Apr 27, 2021
beceed4
f
XadillaX Apr 27, 2021
5cb24c8
f
XadillaX Apr 27, 2021
b42b4ba
f
XadillaX Apr 27, 2021
63b9a49
f
XadillaX Apr 28, 2021
ff1d141
f
XadillaX Apr 28, 2021
6b5eeec
f
XadillaX Apr 28, 2021
ba56cb9
f
XadillaX Apr 28, 2021
5200196
f
XadillaX Apr 28, 2021
074c82c
f
XadillaX Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
f
  • Loading branch information
@XadillaX
XadillaX committed Apr 27, 2021
commit beceed4c63bc5c221a2d220baef5c508142ffbc9
14 changes: 6 additions & 8 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,12 +1215,6 @@ if (internalBinding('config').hasIntl) {

let DOMException;

const lazyInvalidCharError = hideStackFrames((message, name) => {
if (DOMException === undefined)
DOMException = internalBinding('messaging').DOMException;
throw new DOMException('Invalid character', 'InvalidCharacterError');
});

function btoa(input) {
input = `${input}`;
let ret;
Expand All @@ -1229,7 +1223,9 @@ function btoa(input) {
} catch (e) {
if (DOMException === undefined)
DOMException = internalBinding('messaging').DOMException;
throw new DOMException('Invalid character', 'InvalidCharacterError');
let code = 'Error';
if (e.code === 'ERR_INVALID_CHARACTER') code = 'InvalidCharacterError';
throw new DOMException(e.message, code);
}
return ret;
}
Expand All @@ -1242,7 +1238,9 @@ function atob(input) {
} catch (e) {
if (DOMException === undefined)
DOMException = internalBinding('messaging').DOMException;
throw new DOMException('Invalid character', 'InvalidCharacterError');
let code = 'Error';
if (e.code === 'ERR_INVALID_CHARACTER') code = 'InvalidCharacterError';
throw new DOMException(e.message, code);
}
return ret;
}
Expand Down