Skip to content

doc: clarify DiffieHellmanGroup class docs #38363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linkgoron wants to merge 2 commits into from
Closed

doc: clarify DiffieHellmanGroup class docs #38363

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c55c3
doc: clarify DiffieHellmanGroup class docs
Linkgoron Apr 22, 2021
5473d41
fixup! doc: clarify DiffieHellmanGroup class docs
Linkgoron Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: clarify DiffieHellmanGroup class docs 
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.
  • Loading branch information
@Linkgoron
Linkgoron committed Apr 22, 2021
commit 13c55c3b707f91f34ee180ca01b27e8076533ca5
6 changes: 4 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,8 +1114,10 @@ module):
added: v0.7.5
-->

The `DiffieHellmanGroup` class takes a well-known modp group as its argument but
otherwise works the same as `DiffieHellman`.
The `DiffieHellmanGroup` class takes a well-known modp group as its argument.
Works the same as `DiffieHellman`, except that it does not allow changing its
Comment thread
Linkgoron marked this conversation as resolved.
Outdated
keys after creation - i.e. does not implement `setPublicKey` or `setPrivateKey`
Comment thread
Linkgoron marked this conversation as resolved.
Outdated
methods.

```mjs
const { createDiffieHellmanGroup } = await import('crypto');
Expand Down