Skip to content

lib/querystring: Add JSDoc Types #38185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Skn0tt wants to merge 8 commits into from
Closed

lib/querystring: Add JSDoc Types #38185

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd248a6
lib/querystring: Add JSDoc Types
Skn0tt Apr 10, 2021
52c342b
linter
bmeck Apr 10, 2021
514ed2a
linter
bmeck Apr 11, 2021
4b4742a
use bigint primitive form not object wrapped form
bmeck Apr 11, 2021
c5d49fb
nits
bmeck Apr 11, 2021
d63d5f3
lint
bmeck Apr 11, 2021
c5bbc9a
style
bmeck Apr 13, 2021
a7bd3e4
Update lib/querystring.js
targos Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter 
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
  • Loading branch information
@bmeck @VoltrexKeyva
bmeck and VoltrexKeyva authored Apr 11, 2021
commit 514ed2ad567a10316d72c83adfa36ba3a5a168c3
18 changes: 9 additions & 9 deletions lib/querystring.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ function stringifyPrimitive(v) {

/**
* @param {string | number | BigInt | boolean} v
Comment thread
bmeck marked this conversation as resolved.
Outdated
* @param {(v: string) => string} encode
* @returns
* @param {(v: string) => string} encode
* @returns
*/
function encodeStringified(v, encode) {
if (typeof v === 'string')
Expand All @@ -209,20 +209,20 @@ function encodeStringified(v, encode) {
}

/**
* @param {string | number | boolean | null} v
* @param {(v: string) => string} encode
* @param {string | number | boolean | null} v
* @param {(v: string) => string} encode
* @returns {string}
*/
function encodeStringifiedCustom(v, encode) {
return encode(stringifyPrimitive(v));
}

/**
*
* @param {Record<string, string | number | boolean | ReadonlyArray<string> | ReadonlyArray<number> | ReadonlyArray<boolean> | null>} obj
* @param {Record<string, string | number | boolean
* | ReadonlyArray<string | number | boolean> | null>} obj
* @param {string} [sep]
* @param {string} [eq]
* @param {{ encodeURIComponent?: (v: string) => string }} [options]
* @param {string} [eq]
* @param {{ encodeURIComponent?: (v: string) => string }} [options]
* @returns {string}
*/
function stringify(obj, sep, eq, options) {
Expand Down Expand Up @@ -270,7 +270,7 @@ function stringify(obj, sep, eq, options) {
}

/**
* @param {string} str
* @param {string} str
* @returns {number[]}
*/
function charCodes(str) {
Expand Down