Skip to content

deps,debugger: move node-inspect into core #38161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 12 commits into from
Apr 25, 2021
+1,174 −2,214
Merged

deps,debugger: move node-inspect into core #38161

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ca876a
debugger: move node-inspect to internal library
Trott Apr 8, 2021
7ed3969
tools: remove node-inspect from license
Trott Apr 8, 2021
21dc0b0
debugger: remove unused code
Trott Apr 8, 2021
b0713b4
debugger: fix inspect restart on Windows
Trott Apr 20, 2021
807ede7
debugger: accommodate line chunking in Windows
Trott Apr 21, 2021
c4c9614
debugger: allow longer time to connect
Trott Apr 21, 2021
c6b4ab0
test: fix test-inspector-cli-address
Trott Apr 22, 2021
3ef3501
test,debugger: migrate node-inspect tests to core
Trott Apr 9, 2021
e10525f
debugger: replace internal use of deprecated API
Trott Apr 20, 2021
0955aae
test: fix comment typo
Trott Apr 22, 2021
60a0764
debugger: fix race condition/deadlock on initialization
Trott Apr 23, 2021
2a70f4f
test: extend timeout on debugger tests for slower machines
Trott Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debugger: fix race condition/deadlock on initialization 
PR-URL: #38161
Refs: https://github.com/nodejs/node/discussions/36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@Trott
Trott committed Apr 25, 2021
commit 60a07645018406fa4c6c007a022f65574e5df744
23 changes: 10 additions & 13 deletions lib/internal/inspector/inspect_repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,19 +1062,16 @@ function createRepl(inspector) {
}

function initAfterStart() {
const setupTasks = [
Runtime.enable(),
Profiler.enable(),
Profiler.setSamplingInterval({ interval: 100 }),
Debugger.enable(),
Debugger.setPauseOnExceptions({ state: 'none' }),
Debugger.setAsyncCallStackDepth({ maxDepth: 0 }),
Debugger.setBlackboxPatterns({ patterns: [] }),
Debugger.setPauseOnExceptions({ state: pauseOnExceptionState }),
restoreBreakpoints(),
Runtime.runIfWaitingForDebugger(),
];
return Promise.all(setupTasks);
return Runtime.enable()
.then(() => Profiler.enable())
.then(() => Profiler.setSamplingInterval({ interval: 100 }))
.then(() => Debugger.enable())
.then(() => Debugger.setPauseOnExceptions({ state: 'none' }))
.then(() => Debugger.setAsyncCallStackDepth({ maxDepth: 0 }))
.then(() => Debugger.setBlackboxPatterns({ patterns: [] }))
.then(() => Debugger.setPauseOnExceptions({ state: pauseOnExceptionState }))
.then(() => restoreBreakpoints())
.then(() => Runtime.runIfWaitingForDebugger())
}

return function startRepl() {
Expand Down