Skip to content

lib: properly processing JavaScript exceptions on async_hooks fatal error #38106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 3 commits into from
Closed

lib: properly processing JavaScript exceptions on async_hooks fatal error #38106

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f756a
lib: properly processing JavaScript exceptions on async_hooks fatal e…
legendecas Apr 6, 2021
a9af38d
fixup! lib: properly processing JavaScript exceptions on async_hooks …
legendecas Apr 7, 2021
95bcddc
fixup!
legendecas Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! 
Co-authored-by: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@legendecas @addaleax
legendecas and addaleax authored Apr 7, 2021
commit 95bcddc5bf5e9a53a607f0a7a0f61a6a21982baf
3 changes: 1 addition & 2 deletions lib/internal/async_hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ function executionAsyncResource() {

function inspectExceptionValue(e) {
inspect ??= require('internal/util/inspect').inspect;
const o = { message: inspect(e) };
return o;
return { message: inspect(e) };
}

// Used to fatally abort the process if a callback throws.
Expand Down