Skip to content

lib: add brand checks to AbortController and AbortSignal #37720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MattiasBuelens wants to merge 6 commits into from
Closed

lib: add brand checks to AbortController and AbortSignal #37720

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64abc04
lib: add brand checks to AbortController and AbortSignal
MattiasBuelens Mar 11, 2021
048ab00
lib: use optional chaining in brand checks
MattiasBuelens Mar 11, 2021
1de2c66
lib: reformat require for internal/errors
MattiasBuelens Mar 11, 2021
bc87164
test: check if AbortController and AbortSignal validate the receiver
MattiasBuelens Mar 14, 2021
2469b73
test: reword comments
MattiasBuelens Mar 15, 2021
8fa7c54
test: check undefined as well
MattiasBuelens Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: check if AbortController and AbortSignal validate the receiver
  • Loading branch information
@MattiasBuelens
MattiasBuelens committed Mar 15, 2021
commit bc871642b1292a64a300f967e693b2b25305f81e
60 changes: 60 additions & 0 deletions test/parallel/test-abortcontroller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,63 @@ const { ok, strictEqual, throws } = require('assert');
const signal = AbortSignal.abort();
ok(signal.aborted);
}

{
// Test that AbortController properties and methods
// validate the receiver object
const acSignalGet = Object.getOwnPropertyDescriptor(
AbortController.prototype,
'signal'
).get;
const acAbort = AbortController.prototype.abort;

const goodController = new AbortController();
ok(acSignalGet.call(goodController));
acAbort.call(goodController);

const badAbortControllers = [
null,
0,
NaN,
true,
'AbortController',
Object.create(AbortController.prototype)
];
for (const badController of badAbortControllers) {
throws(
() => acSignalGet.call(badController),
{ code: 'ERR_INVALID_THIS', name: 'TypeError' }
);
throws(
() => acAbort.call(badController),
{ code: 'ERR_INVALID_THIS', name: 'TypeError' }
);
}
}

{
// Test that AbortSignal properties
// validate the receiver object
const signalAbortedGet = Object.getOwnPropertyDescriptor(
AbortSignal.prototype,
'aborted'
).get;

const goodSignal = new AbortController().signal;
strictEqual(signalAbortedGet.call(goodSignal), false);

const badAbortSignals = [
null,
0,
NaN,
true,
'AbortSignal',
Object.create(AbortSignal.prototype)
];
for (const badSignal of badAbortSignals) {
throws(
() => signalAbortedGet.call(badSignal),
{ code: 'ERR_INVALID_THIS', name: 'TypeError' }
);
}
}