Skip to content

feat(stream): make Readable.from performance better #37609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wwwzbwcom wants to merge 11 commits into from
+58 −19
Closed

feat(stream): make Readable.from performance better #37609

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
72e1801
feat: make Readable.from performance better
wwwzbwcom Mar 5, 2021
5a4bd1c
fix: fix promise resolve
wwwzbwcom Mar 8, 2021
75d8e08
fix: fix async spelling
wwwzbwcom Mar 8, 2021
7a9b6cd
chore: change if statement to tertiary operator
wwwzbwcom Mar 8, 2021
0f81421
chore: Update lib/internal/streams/from.js, fix according to suggestion
wwwzbwcom Mar 8, 2021
c9bbe37
fix: remove extra comment
wwwzbwcom Mar 8, 2021
8b69392
benchmark(stream): add stream from benchmark
Mar 12, 2021
84b9d83
fix: fix lint issue
Mar 12, 2021
fdd1021
feat: improve thenable check in readable-from
wwwzbwcom Mar 18, 2021
4d7ddf7
fix: check value is null
wwwzbwcom Mar 18, 2021
286b2ee
fix: fix lint issue
wwwzbwcom Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove extra comment
  • Loading branch information
@wwwzbwcom wwwzbwcom
wwwzbwcom authored and wwwzbwcom committed Mar 12, 2021
commit c9bbe37ed8dc58cfa472c7d3fba341f09e7f9678
1 change: 0 additions & 1 deletion lib/internal/streams/from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ function from(Readable, iterable, opts) {
const readable = new Readable({
objectMode: true,
highWaterMark: 1,
// me
// TODO(ronag): What options should be allowed?
...opts,
});
Expand Down