Skip to content

[v12.x backport] deps: V8: cherry-pick beebee4f80ff #37578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juanarbol wants to merge 2 commits into from
Closed

[v12.x backport] deps: V8: cherry-pick beebee4f80ff #37578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3fc8d
deps: V8: cherry-pick beebee4f80ff
psmarshall Aug 5, 2020
a6eae67
test: add cpu-profiler-crash test
santigimeno Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add cpu-profiler-crash test 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: #37293
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
@santigimeno @juanarbol
santigimeno authored and juanarbol committed Mar 2, 2021
commit a6eae67e0144f5299ebad0480e45fbe1dcbe2f4e
16 changes: 16 additions & 0 deletions test/addons/cpu-profiler-crash/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#include "node.h"
#include "v8.h"
#include "v8-profiler.h"

static void StartCpuProfiler(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::CpuProfiler* profiler = v8::CpuProfiler::New(args.GetIsolate());
v8::Local<v8::String> profile_title = v8::String::NewFromUtf8(
args.GetIsolate(),
"testing",
v8::NewStringType::kInternalized).ToLocalChecked();
profiler->StartProfiling(profile_title, true);
}

NODE_MODULE_INIT(/* exports, module, context */) {
NODE_SET_METHOD(exports, "startCpuProfiler", StartCpuProfiler);
}
9 changes: 9 additions & 0 deletions test/addons/cpu-profiler-crash/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
'targets': [
{
'target_name': 'binding',
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
20 changes: 20 additions & 0 deletions test/addons/cpu-profiler-crash/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';

// This test crashes most of the time unless the v8 patch:
// https://github.com/v8/v8/commit/beebee4f80ff2eb91187ef1e8fa00b8ff82a20b3
// is applied.
const common = require('../../common');
const bindings = require(`./build/${common.buildType}/binding`);

function fn() { setImmediate(fn); }
setInterval(function() {
for (let i = 0; i < 1000000; i++)
fn();
clearInterval(this);
setTimeout(process.reallyExit, 2000);
}, 0);


setTimeout(() => {
bindings.startCpuProfiler();
}, 1000);