Skip to content

crypto: add optional callback to crypto.sign and crypto.verify #37500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 11 commits into from
Closed

crypto: add optional callback to crypto.sign and crypto.verify #37500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3cf3b94
crypto: add optional callback to crypto.sign and crypto.verify
panva Feb 24, 2021
26c3c3d
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Feb 24, 2021
0788fca
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Feb 24, 2021
c5f956f
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Feb 25, 2021
66b1802
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Feb 26, 2021
53169cc
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 1, 2021
b4f69b8
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 1, 2021
0c9f8cf
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 8, 2021
f26d4b0
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 8, 2021
670960f
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 8, 2021
78440b9
fixup! crypto: add optional callback to crypto.sign and crypto.verify
panva Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! crypto: add optional callback to crypto.sign and crypto.verify
  • Loading branch information
@panva
panva committed Mar 10, 2021
commit 670960f48fdd124f76cbb41412cd22f0de1a7a65
9 changes: 7 additions & 2 deletions src/crypto/crypto_ec.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#include <openssl/ec.h>
#include <openssl/ecdh.h>

#include <algorithm>

namespace node {

using v8::Array;
Expand Down Expand Up @@ -959,19 +961,22 @@ ByteSource ConvertToWebCryptoSignature(
return ByteSource();

DSA_SIG_get0(dsasig.get(), &pr, &ps);
len = BN_num_bytes(pr);
len = std::max(BN_num_bytes(pr), BN_num_bytes(ps));
}
}

CHECK_GT(len, 0);

char* outdata = MallocOpenSSL<char>(len * 2);
memset(outdata, 0, len * 2);
ByteSource out = ByteSource::Allocated(outdata, len * 2);
unsigned char* ptr = reinterpret_cast<unsigned char*>(outdata);

if (!BN_bn2binpad(pr, ptr, len) || !BN_bn2binpad(ps, ptr + len, len)) {
if (BN_bn2binpad(pr, ptr, len) <= 0 ||
BN_bn2binpad(ps, ptr + len, len) <= 0) {
return ByteSource();
}

return out;
}

Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-crypto-async-sign-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,11 @@ test('ec_secp256k1_public.pem', 'ec_secp256k1_private.pem', 'sha384', false,
{ dsaEncoding: 'ieee-p1363' });

// DSA w/ der signature encoding
test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256',
test('dsa_public.pem', 'dsa_private.pem', 'sha256',
false);
test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256',
test('dsa_public.pem', 'dsa_private.pem', 'sha256',
false, { dsaEncoding: 'der' });

// DSA w/ ieee-p1363 signature encoding
test('dsa_public_1025.pem', 'dsa_private_1025.pem', 'sha256', false,
test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
{ dsaEncoding: 'ieee-p1363' });