Skip to content

node-api: force env shutdown deferring behavior #37303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 5 commits into from
Closed

node-api: force env shutdown deferring behavior #37303

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cf6a26
node-api: force env shutdown deferring behavior
Feb 10, 2021
167bb7f
add test
Feb 10, 2021
9f723be
heed the linter
Feb 10, 2021
df5463b
handle the case where the reference is not deleted in its destructor
Feb 11, 2021
21e5b1d
put the _finalize_ran = true back in the else body
Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
heed the linter
  • Loading branch information
Gabriel Schulhof @gabrielschulhof
Gabriel Schulhof authored and gabrielschulhof committed Feb 18, 2021
commit 9f723be39abe57ef9d6e6e1e0a78252d7132049e
2 changes: 1 addition & 1 deletion test/js-native-api/test_reference_double_free/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ const { buildType } = require('../../common');

const addon = require(`./build/${buildType}/test_reference_double_free`);

{ const obj = new addon.MyObject(); }
{ new addon.MyObject(); }