Skip to content

doc: mention adding Fixes to collaborator onboarding PR #37097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 1 commit into from
Closed

doc: mention adding Fixes to collaborator onboarding PR #37097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: mention adding Fixes to collaborator onboarding PR 
Also update the example to include the Fixes url.
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 27, 2021
commit 25686969e69ba1a13593ad300cfbd347a1053b05
9 changes: 6 additions & 3 deletions onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
## Exercise: Make a PR adding yourself to the README

* Example:
<https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
-1`
<https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
* For raw commit message:
`git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
so that when the commit lands, the nomination issue url will be
automatically closed.
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
labels.
* Run CI on the PR. Use the `node-test-pull-request` CI task.
Expand Down