Skip to content

test: fixup flaky test-crypto-x509 on windows #36966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
Jan 16, 2021
Merged

test: fixup flaky test-crypto-x509 on windows #36966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fixup flaky test-crypto-x509 on windows 
PR-URL: #36966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@jasnell @aduh95
jasnell authored and aduh95 committed Jan 16, 2021
commit 433afd9e3969481917237f340cf7900269c4acf0
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-x509.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const der = Buffer.from(
assert(x509.publicKey);
assert.strictEqual(x509.publicKey.type, 'public');

assert.strictEqual(x509.toString(), cert.toString());
assert.strictEqual(x509.toString().replaceAll('\r\n', '\n'), cert.toString());
assert.strictEqual(x509.toJSON(), x509.toString());

assert(x509.checkPrivateKey(privateKey));
Expand Down