Skip to content

assert: refactor to avoid unsafe array iteration #36754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 4 commits into from
Closed

assert: refactor to avoid unsafe array iteration #36754

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92517c1
assert: refactor to avoid unsafe array iteration
aduh95 Jan 1, 2021
3c046c5
fixup! assert: refactor to avoid unsafe array iteration
aduh95 Jan 3, 2021
3d002ff
fixup! assert: refactor to avoid unsafe array iteration
aduh95 Jan 3, 2021
7c91e3c
fixup! assert: refactor to avoid unsafe array iteration
aduh95 Jan 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! assert: refactor to avoid unsafe array iteration
  • Loading branch information
@aduh95
aduh95 committed Jan 3, 2021
commit 7c91e3cbae6545e13ae8415b1130e936957a1d6a
4 changes: 2 additions & 2 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,9 +740,9 @@ async function waitForActual(promiseFn) {
return NO_EXCEPTION_SENTINEL;
}

function expectsError(stackStartFn, actual, { 0: error, 1: message }) {
function expectsError(stackStartFn, actual, { 0: error, 1: message, length }) {
if (typeof error === 'string') {
if (arguments.length === 4) {
if (length === 2) {
throw new ERR_INVALID_ARG_TYPE('error',
['Object', 'Error', 'Function', 'RegExp'],
error);
Expand Down