Skip to content

repl: refactor to avoid unsafe array iteration #36663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 11 commits into from
Closed

repl: refactor to avoid unsafe array iteration #36663

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
767d670
repl: refactor to avoid unsafe array iteration
RaisinTen Dec 28, 2020
a48dd1f
fixup! repl: refactor to avoid unsafe array iteration
aduh95 Dec 28, 2020
7e0103d
fixup! repl: refactor to avoid unsafe array iteration
aduh95 Dec 29, 2020
9eb3d45
fixup! fixup! repl: refactor to avoid unsafe array iteration
aduh95 Dec 29, 2020
878dbe2
fixup! repl: refactor to avoid unsafe array iteration
RaisinTen Jan 13, 2021
4fab6a8
fixup! fixup! repl: refactor to avoid unsafe array iteration
RaisinTen Jan 14, 2021
f1f9f77
fixup! repl: refactor to avoid unsafe array iteration
RaisinTen Jan 15, 2021
4d083aa
fixup! fixup! repl: refactor to avoid unsafe array iteration
RaisinTen Jan 15, 2021
7eca9ce
Revert "fixup! fixup! repl: refactor to avoid unsafe array iteration"
RaisinTen Jan 16, 2021
4cd841f
Revert "fixup! repl: refactor to avoid unsafe array iteration"
RaisinTen Jan 16, 2021
d94f46c
Revert "fixup! fixup! repl: refactor to avoid unsafe array iteration"
RaisinTen Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "fixup! fixup! repl: refactor to avoid unsafe array iteration" 
This reverts commit 4fab6a8.
  • Loading branch information
@RaisinTen
RaisinTen committed Jan 17, 2021
commit d94f46c94c3f2a263a10c9d0239f95a1bb7c7372
8 changes: 3 additions & 5 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const {
RegExp,
RegExpPrototypeTest,
RegExpPrototypeToString,
SafeArrayIterator,
SafeStringIterator,
SafeMap,
SafeSet,
Expand Down Expand Up @@ -1871,19 +1870,18 @@ function tryStringify(arg) {
}

function format(...args) {
return formatWithOptionsInternal(undefined, ...new SafeArrayIterator(args));
return formatWithOptionsInternal(undefined, args);
Comment thread
aduh95 marked this conversation as resolved.
Resolved
}

function formatWithOptions(inspectOptions, ...args) {
if (typeof inspectOptions !== 'object' || inspectOptions === null) {
throw new ERR_INVALID_ARG_TYPE(
'inspectOptions', 'object', inspectOptions);
}
return formatWithOptionsInternal(inspectOptions,
...new SafeArrayIterator(args));
return formatWithOptionsInternal(inspectOptions, args);
}

function formatWithOptionsInternal(inspectOptions, ...args) {
function formatWithOptionsInternal(inspectOptions, args) {
const first = args[0];
let a = 0;
let str = '';
Expand Down