Skip to content

lib: remove v8_prof_polyfill from eslint ignore list #36537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 4 commits into from
Closed

lib: remove v8_prof_polyfill from eslint ignore list #36537

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c85fe22
lib: remove v8_prof_polyfill from eslint ignore list
aduh95 Dec 15, 2020
57843b6
fixup! lib: remove v8_prof_polyfill from eslint ignore list
aduh95 Dec 15, 2020
62bb36b
fixup! lib: remove v8_prof_polyfill from eslint ignore list
aduh95 Jan 2, 2021
d5e972a
fixup! lib: remove v8_prof_polyfill from eslint ignore list
aduh95 Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! lib: remove v8_prof_polyfill from eslint ignore list
  • Loading branch information
@aduh95
aduh95 committed Dec 15, 2020
commit 57843b63fa1d771ca15d22b82f7fe598579a7283
6 changes: 2 additions & 4 deletions lib/internal/v8_prof_polyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@

'use strict';

const {
JSONStringify,
} = primordials;
/* eslint-disable node-core/prefer-primordials */

module.exports = { versionCheck };

Expand Down Expand Up @@ -83,7 +81,7 @@ function readline() {
if (bytes === 0) {
process.emitWarning(`Profile file ${logFile} is broken`, {
code: 'BROKEN_PROFILE_FILE',
detail: `${JSONStringify(line)} at the file end is broken`
detail: `${JSON.stringify(line)} at the file end is broken`
});
return '';
}
Expand Down