Skip to content

doc: fix writable._construct() example #36509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkbaranovskyi wants to merge 1 commit into from
Closed

doc: fix writable._construct() example #36509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Two bugs in the _construct() example fixed
  • Loading branch information
@mkbaranovskyi
mkbaranovskyi authored Dec 14, 2020
commit 22764c45c6be6a9756c235f9c0bcf63e8cd41dcb
3 changes: 1 addition & 2 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,10 +2078,9 @@ class WriteStream extends Writable {
constructor(filename) {
super();
this.filename = filename;
this.fd = fd;
}
_construct(callback) {
fs.open(this.filename, (fd, err) => {
fs.open(this.filename, (err, fd) => {
if (err) {
callback(err);
} else {
Expand Down