Skip to content

src: use correct outer Context’s microtask queue #36482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

src: use correct outer Context’s microtask queue #36482

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
090a3f6
deps: V8: backport 4bf051d536a1
addaleax Dec 11, 2020
299c63d
src: use correct outer Context’s microtask queue
addaleax Dec 8, 2020
bde7245
fixup! src: use correct outer Context’s microtask queue
addaleax Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: use correct outer Context’s microtask queue
  • Loading branch information
@addaleax
addaleax committed Dec 11, 2020
commit bde7245ebcabd11402b1af564288f4ea02a5bd0d
3 changes: 1 addition & 2 deletions test/cctest/test_environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,8 +653,7 @@ TEST_F(EnvironmentTest, NestedMicrotaskQueue) {
"require('vm').runInNewContext("
" 'Promise.resolve().then(() => mustCall(1 << 2))',"
" { mustCall }"
");"
).ToLocalChecked();
");").ToLocalChecked();
EXPECT_EQ(callback_calls, 1 << 1);
isolate_->PerformMicrotaskCheckpoint();
EXPECT_EQ(callback_calls, 1 << 1);
Expand Down