Skip to content

fs: throws error if position argument is bigint in fs.readSync & fs.read #36198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darvesh wants to merge 6 commits into from
Closed

fs: throws error if position argument is bigint in fs.readSync & fs.read #36198

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41b0999
fs: throws error if position argument is bigint
darvesh Nov 20, 2020
b489db1
test: position argument in fs.read
darvesh Nov 20, 2020
eae1ee3
fix: formatting
darvesh Nov 20, 2020
dd99afd
fix: linter errors
darvesh Nov 20, 2020
25cc46c
test: fix fs.read message
darvesh Nov 20, 2020
ab7e3be
fix: linter max line length
darvesh Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: throws error if position argument is bigint 
Fixes: #36190
  • Loading branch information
@darvesh
darvesh committed Nov 20, 2020
commit 41b099986da5a6d40c981c31e89fbc78d17ae5aa
6 changes: 6 additions & 0 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,9 @@ function read(fd, buffer, offset, length, position, callback) {

validateOffsetLengthRead(offset, length, buffer.byteLength);

if(typeof position === 'bigint')
throw new ERR_INVALID_ARG_TYPE('position', 'number', position);

if (!NumberIsSafeInteger(position))
position = -1;

Expand Down Expand Up @@ -595,6 +598,9 @@ function readSync(fd, buffer, offset, length, position) {

validateOffsetLengthRead(offset, length, buffer.byteLength);

if(typeof position === 'bigint')
throw new ERR_INVALID_ARG_TYPE('position', 'number', position);

if (!NumberIsSafeInteger(position))
position = -1;

Expand Down