Skip to content

errors: do not call resolve on URLs with schemes #35903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 10 commits into from
Closed

errors: do not call resolve on URLs with schemes #35903

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
44f20fc
errors: do not call resolve on URLs with schemes
Oct 31, 2020
dd0949f
Update lib/internal/source_map/source_map_cache.js
Nov 1, 2020
3e78647
Update lib/internal/source_map/prepare_stack_trace.js
Nov 1, 2020
596cf2a
Update lib/internal/source_map/prepare_stack_trace.js
Nov 1, 2020
8933b5c
Update lib/internal/source_map/source_map_cache.js
Nov 1, 2020
6ace772
Update lib/internal/source_map/prepare_stack_trace.js
Nov 1, 2020
21124ef
errors: use URL for resolution
Nov 1, 2020
3c1a7ca
chore: address code review
Nov 1, 2020
eafd35e
chore: fix linting
Nov 1, 2020
c85b480
chore: fix path resolution
Nov 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/source_map/source_map_cache.js 
Co-authored-by: devsnek <me@gus.host>
  • Loading branch information
Benjamin E. Coe @devsnek
Benjamin E. Coe and devsnek authored Nov 1, 2020
commit dd0949f019c9cf36f00396bf0f4dad9c5208a649
2 changes: 1 addition & 1 deletion lib/internal/source_map/source_map_cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function sourcesToAbsolute(base, data) {
data.sources = data.sources.map((source) => {
source = (data.sourceRoot || '') + source;
// An absolute URI does not need to be resolved, return it:
if (source.match(/(?<scheme>^\w+):\/\//)) return source;
if (/(^\w+):/.test(source)) return source;
Comment thread
bcoe marked this conversation as resolved.
Resolved
Comment thread
bcoe marked this conversation as resolved.
Resolved
if (!/^[\\/]/.test(source[0])) {
source = resolve(base, source);
}
Expand Down