Skip to content

quic: stream not reading last chunk on close when using async iterator #35798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmomtchev wants to merge 1 commit into from
Closed

quic: stream not reading last chunk on close when using async iterator #35798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream: fix async iter not reading last chunk on close 
The async iterator can sometimes miss the last chunk
when there has been an asynchronous event
and a null chunk as used by
test-quic-simple-server-uni.js

Fixes: #35789
  • Loading branch information
@mmomtchev
mmomtchev committed Oct 25, 2020
commit 01f0d7249873d7a619eb57b4767942526d3beebc
2 changes: 1 addition & 1 deletion lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ async function* createAsyncIterator(stream) {

try {
while (true) {
const chunk = stream.destroyed ? null : stream.read();
const chunk = errorEmitted ? null : stream.read();
if (chunk !== null) {
yield chunk;
} else if (errorEmitted) {
Expand Down