Skip to content

[v12 backport] ESM (named exports for CJS, package.json docs, subpath export patterns, warning removal) #35757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 17 commits into from
Closed

[v12 backport] ESM (named exports for CJS, package.json docs, subpath export patterns, warning removal) #35757

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
21fca91
module: named exports for CJS via static analysis
guybedford May 15, 2020
ade34f3
module: refine module type mismatch error cases
guybedford Sep 30, 2020
57b6119
module: update to cjs-module-lexer@0.4.0
guybedford Oct 4, 2020
4c714c7
doc: rename module pages
aduh95 Aug 7, 2020
b517ae8
doc: move package config docs to separate page
aduh95 Aug 7, 2020
cc303a9
doc: document support for package.json fields
aduh95 Aug 7, 2020
7b76e75
module: exports pattern support
guybedford Aug 12, 2020
55d15e6
doc: edit subpath export patterns introduction
Trott Sep 18, 2020
3b49965
doc: refine require/import conditions constraints
guybedford Sep 23, 2020
ee644b4
doc: packages docs feedback
guybedford Sep 27, 2020
728ddbf
doc: copyedit packages.md
Trott Sep 30, 2020
e1958d5
doc: fix conditional exports flag removal version
aduh95 Sep 30, 2020
6c27021
doc: add history entry for exports patterns
aduh95 Sep 29, 2020
e8a7201
doc,esm: add history support info
aduh95 Sep 28, 2020
63fffcf
module: remove experimental modules warning
guybedford Feb 26, 2020
18c9216
doc,esm: document experimental warning removal
aduh95 Oct 22, 2020
3e18962
esm: use "node:" namespace for builtins
guybedford Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: edit subpath export patterns introduction 
* Use parallel construction in the two sentences
* Backticks around _package.json_ to match rest of file
* Add comma for readability
* Own the recommendation ("we recommend")

PR-URL: #35254
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
  • Loading branch information
@Trott @aduh95
Trott authored and aduh95 committed Oct 23, 2020
commit 55d15e64ad2feb413ef55259edd23de1946ce6a4
6 changes: 3 additions & 3 deletions doc/api/packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ import submodule from 'es-module-package/private-module.js';

> Stability: 1 - Experimental

Explicitly listing each exports subpath entry is recommended for packages with
a small number of exports. But for packages that have very large numbers of
subpaths this can start to cause package.json bloat and maintenance issues.
For packages with a small number of exports, we recommend explicitly listing
each exports subpath entry. But for packages that have large numbers of
subpaths, this might cause `package.json` bloat and maintenance issues.

For these use cases, subpath export patterns can be used instead:

Expand Down