Skip to content

build: enable Clang-cl Windows builds #35433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 12 commits into from
Closed

build: enable Clang-cl Windows builds #35433

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ff3a4ec
tools: hack gyp to generate clang-cl solutions
targos Jul 4, 2020
26e51ff
deps: add missing zlib includes
targos Jul 4, 2020
711a822
hack ICU
targos Sep 30, 2020
bbf0efc
disable some workflows
targos Oct 22, 2022
3ccb17d
remove macros
targos Oct 22, 2022
273cb2b
set clang to 1
targos Nov 20, 2022
6ec7554
fix pch
targos Nov 20, 2022
1f149ca
fix build on clangcl, except for v8 assembly (#9)
lemire Dec 15, 2023
d4fe780
fix: embed snapshot asm into a source file like v8 does
lemire Jan 3, 2024
9d7c136
fix: lib paths and remove unneeded masm
lemire Jan 3, 2024
1a5726a
fix: only build embedded.cc when under Windows. (#11)
lemire Jan 5, 2024
d5302f5
fix: only generate embedded.cc under Windows. (#12)
lemire Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove macros
  • Loading branch information
@targos
targos committed Apr 30, 2024
commit 3ccb17d834350c49bd2cba7fa64249d2b5a58059
2 changes: 1 addition & 1 deletion deps/v8/src/heap/cppgc/heap-base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class V8_EXPORT_PRIVATE HeapBase : public cppgc::HeapHandle {
friend class cppgc::testing::Heap;
};

class V8_NODISCARD V8_EXPORT_PRIVATE ClassNameAsHeapObjectNameScope final {
class ClassNameAsHeapObjectNameScope final {
Comment thread
targos marked this conversation as resolved.
Outdated
public:
explicit ClassNameAsHeapObjectNameScope(HeapBase& heap);
~ClassNameAsHeapObjectNameScope();
Expand Down