Skip to content

zlib: only apply drain listener if given callback #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 3 commits into from
Closed

zlib: only apply drain listener if given callback #3534

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce8a3e1
zlib: pass kind to recursive calls to flush
Oct 26, 2015
599e48d
zlib: only apply drain listener if given callback
CraigCav Oct 26, 2015
0d62987
test: add test-zlib-flush-drain
Nov 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
zlib: only apply drain listener if given callback 
When stream.flush() is called without a callback, an empty listener is
being added. Since flush may be called multiple times to push SSE's
down to the client, multiple noop listeners are being added. This in
turn causes the memory leak detected message.
  • Loading branch information
@CraigCav Myles Borins
CraigCav authored and Myles Borins committed Nov 13, 2015
commit 599e48d338f6d045e03139b01f28dc0c80004de5
7 changes: 3 additions & 4 deletions lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,9 @@ Zlib.prototype.flush = function(kind, callback) {
if (callback)
this.once('end', callback);
} else if (ws.needDrain) {
var self = this;
this.once('drain', function() {
self.flush(kind, callback);
});
if (callback) {
this.once('drain', () => this.flush(kind, callback));
}
} else {
this._flushFlag = kind;
this.write(new Buffer(0), '', callback);
Expand Down