Skip to content

doc: put release script specifics in details #35260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 2 commits into from
Closed

doc: put release script specifics in details #35260

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f121c9
doc: put release script specifics in details
MylesBorins Sep 18, 2020
bb13292
Update doc/guides/releases.md
MylesBorins Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: put release script specifics in details 
Listing all the steps can be confusing an make it seem like
the releaser is meant to run each of these steps manually. In fact
I personally did that my first release.

Let's put those steps in a details block to make it more obvious
that it is informational and not steps to follow
  • Loading branch information
@MylesBorins
MylesBorins committed Sep 18, 2020
commit 5f121c962a73858e3bba82b9cabb75adeb9d2ac7
2 changes: 2 additions & 0 deletions doc/guides/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,7 @@ $ ./tools/release.sh -i ~/.ssh/node_id_rsa

`tools/release.sh` will perform the following actions when run:

<details>
**a.** Select a GPG key from your private keys. It will use a command similar
Comment thread
MylesBorins marked this conversation as resolved.
Resolved
to: `gpg --list-secret-keys` to list your keys. If you don't have any keys, it
will bail. If you have only one key, it will use that. If you have more than
Expand Down Expand Up @@ -631,6 +632,7 @@ SHASUMS256.txt.sig.

**g.** Upload the `SHASUMS256.txt` files back to the server into the release
directory.
</details>

If you didn't wait for ARM builds in the previous step before promoting the
release, you should re-run `tools/release.sh` after the ARM builds have
Expand Down