Skip to content

[v12.x] deps: V8: backport 3f071e3e7e15 #35038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miladfarca wants to merge 11 commits into from
Closed

[v12.x] deps: V8: backport 3f071e3e7e15 #35038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
04df3da
src: do not crash if ToggleAsyncHook fails during termination
addaleax Jul 14, 2020
078ee99
assert: port common.mustCall() to assert
DavenportEmma Feb 27, 2020
6c3d968
stream: pipeline should use req.abort() to destroy response
ronag Dec 21, 2019
8069f8d
http: don't throw on `Uint8Array`s for `http.ServerResponse#write`
rexagod May 3, 2020
11a87ed
http: fix incorrect headersTimeout measurement
OrKoN Oct 30, 2019
b7fb94d
doc: deprecate process.umask() with no arguments
cjihrig Mar 26, 2020
bb0cc00
doc: split process.umask() entry into two
Trott Apr 7, 2020
e5049f2
deps: V8: cherry-pick 7889803e82d3
zjiaz Jul 4, 2020
729799d
module: deprecate module.parent
aduh95 Mar 11, 2020
56e51d0
Merge branch 'v12.x-staging' of https://github.com/nodejs/node into v…
Sep 18, 2020
c10bfdc
deps: V8: backport 3f071e3e7e15
Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 7889803e82d3 
Original commit message:

    [mips] Use t9 as the function call register.

    on mips, we should use t9 when jump to a ExternalReference, because
    the callee function will consider t9 as the function start address.

    Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417
    Auto-Submit: Yu Yin <xwafish@gmail.com>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63988}

Refs: v8/v8@7889803

PR-URL: #34214
Fixes: #33703
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
  • Loading branch information
@zjiaz @BethGriggs
zjiaz authored and BethGriggs committed Aug 18, 2020
commit e5049f299167b5fc4c684e496e63f0ce9f28e14d
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.39',
'v8_embedder_string': '-node.40',

##### V8 defaults for Node.js #####

Expand Down
6 changes: 2 additions & 4 deletions deps/v8/src/codegen/mips/macro-assembler-mips.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3853,10 +3853,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
}

void TurboAssembler::Jump(const ExternalReference& reference) {
UseScratchRegisterScope temps(this);
Register scratch = temps.Acquire();
li(scratch, reference);
Jump(scratch);
li(t9, reference);
Jump(t9);
}

void MacroAssembler::JumpIfIsInRange(Register value, unsigned lower_limit,
Expand Down
6 changes: 2 additions & 4 deletions deps/v8/src/codegen/mips64/macro-assembler-mips64.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4202,10 +4202,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
}

void TurboAssembler::Jump(const ExternalReference& reference) {
UseScratchRegisterScope temps(this);
Register scratch = temps.Acquire();
li(scratch, reference);
Jump(scratch);
li(t9, reference);
Jump(t9);
}

// Note: To call gcc-compiled C code on mips, you must call through t9.
Expand Down