Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
a43b7ff
meta: remove non-existent quic from CODEOWNERS
richardlau Aug 27, 2020
29b048b
doc: use links to MS guide in style guide
Trott Aug 21, 2020
971b7ac
test: simplify test-vm-memleak
Trott Aug 22, 2020
4cf93bb
doc: use "previous"/"preceding" instead of "above" as modifier
Trott Aug 22, 2020
755f9e4
build,deps: add gen-openssl target
evanlucas Aug 6, 2020
f1fcd66
deps: add openssl support for arm64
evanlucas Jul 7, 2020
d06e158
build: add support for build on arm64
evanlucas Jul 7, 2020
be71e71
meta: enable wasi for CODEOWNERS
gengjiawen Aug 23, 2020
fffba3a
errors: use `ErrorPrototypeToString` from `primordials` object
ExE-Boss Aug 23, 2020
657292e
doc: fix broken markdown/display in cli.html
Trott Aug 23, 2020
2fe9509
doc: improve link-local text in dgram.md
Trott Aug 21, 2020
7ad629e
tools,doc: remove "toc" anchor name
Trott Aug 23, 2020
044297f
src,doc: rephrase for clarity
wjabbour Aug 22, 2020
bcc1d43
src,doc: fix grammar due to missing 'is'
wjabbour Aug 24, 2020
f6a5999
src,doc: fix wording to refer to context, not environment
wjabbour Aug 22, 2020
18b04ab
policy: implement scopes field
bmeck Jul 17, 2020
4782ec7
doc: use consistent typography for node-addon-api
Trott Aug 24, 2020
fbd18be
doc: provide more guidance about process.version
Trott Aug 24, 2020
b091681
doc: fix CHANGELOG.md parsing issue
juanarbol Aug 25, 2020
3c32fe0
n-api: re-implement async env cleanup hooks
Aug 17, 2020
0e09ff8
doc: make minor fixes to maintaining-openssl.md
Trott Aug 25, 2020
aee3b85
doc: simplify "make use of" to "use"
Trott Aug 21, 2020
90f9348
deps: update brotli to v1.0.9
addaleax Aug 26, 2020
94528f5
zlib: replace usage of internal stream state with public api
lundibundi Aug 23, 2020
fcb211f
net: replace usage of internal stream state with public api
lundibundi Aug 23, 2020
1589f0e
doc: make general copy-edit changes to policy.md
Trott Aug 26, 2020
8aac42c
perf_hooks: add idleTime and event loop util
trevnorris Aug 25, 2020
31098a4
doc: make minor improvements to query string sentence in http2.md
Trott Aug 26, 2020
2407a7a
doc: add a note about possible missing lines to readline.asyncIterator
mikhalev-im Aug 8, 2020
75d1612
test: make test-tls-reuse-host-from-socket pass without internet
Trott Aug 28, 2020
9057a16
test: add readline test for escape sequence
Trott Aug 28, 2020
ee6a583
test: fix typo in test/parallel/test-icu-punycode.js
watilde Aug 26, 2020
94c6e09
doc: replace require() with reference links in http2.md
Trott Aug 28, 2020
f537c86
stream: allow using `.push()`/`.unshift()` during `once('data')`
addaleax Aug 28, 2020
db8c66b
esm: shorten ERR_UNSUPPORTED_ESM_URL_SCHEME message
Trott Aug 19, 2020
7afb67f
build: use latest node-core-utils from npm
lundibundi Aug 29, 2020
46766a1
build: use autorebase option for git node land
lundibundi Aug 29, 2020
ca0302e
doc: arrange perf_hooks entries alphabetically
Trott Aug 29, 2020
df76c89
doc: recommend URL() over url.parse() in http2 doc
Trott Aug 29, 2020
514a538
doc: fix typos in buffer doc
robhybrid Aug 30, 2020
f4524b8
doc: fix broken link to writableEnded in deprecations doc
Trott Aug 30, 2020
a0656ff
doc: fix broken link to response.finished in deprecations doc
Trott Aug 30, 2020
287ce7b
doc: fix broken link to response.writableFinished in deprecations doc
Trott Aug 30, 2020
2598527
doc: drop the --production flag for installing windows-build-tools
DeeDeeG Aug 29, 2020
5f24cea
stream: fix Readable stream state properties
lundibundi Aug 23, 2020
b698d2e
test: remove incorrect debug() in test-policy-integrity
Trott Aug 28, 2020
9aba579
doc: change effected to affected
wjabbour Aug 30, 2020
2ab33c5
buffer: also alias BigUInt methods
addaleax Aug 28, 2020
52be37c
doc,tools: remove malfunctioning Linux manpage linker
Trott Aug 30, 2020
d6c796b
build: close stalled issues and PRs with github action
phillipj Jul 29, 2020
7b72990
build: comment about auto close when stalled via with github action
phillipj Aug 10, 2020
fb2111e
tools,doc: fix global table of content active element
aduh95 Aug 29, 2020
f1217d6
doc: revise commit-queue.md
Trott Sep 1, 2020
a420184
doc: use period consistently in man page
Trott Aug 26, 2020
b6f3ae8
tools,doc: allow page titles to contain inline code
aduh95 Aug 31, 2020
c47d319
tools: update ESLint to 7.8.0
cjihrig Sep 1, 2020
62cc3b8
tools: update ESLint to 7.8.1
cjihrig Sep 1, 2020
cc0aaf2
doc: error code fix in resolver spec
guybedford Aug 31, 2020
1be6956
build: require "allow edits" to be checked
ljharb Aug 31, 2020
1bf5d1a
querystring: manage percent character at unescape
watilde Sep 1, 2020
44d89a9
crypto: add randomInt function
olalonde Aug 2, 2020
8c207c6
doc: refactor deprecation anchors
aduh95 Aug 31, 2020
3d41ff2
tools: add banner to lint-md.js by rollup.config.js
KuthorX Jul 7, 2020
73ef3f2
src: disallow JS execution during exit()
addaleax Sep 2, 2020
789798b
src: add get/set pair for env context awareness
codebytere Sep 1, 2020
593236a
doc: change color contrast for accessibility
Trott Sep 4, 2020
9011c87
test: change var to let
PoojaDurgad Aug 24, 2020
a756b92
test: use mustCall() in test-http-timeout
PoojaDurgad Aug 25, 2020
a846a9f
doc: change 'be will' to 'will be'
zombieleet Aug 31, 2020
c3a3cb6
doc: fix a typo of microtaskMode
shigma Aug 30, 2020
1ae674c
doc: fix malformed hashes in assert.md
Trott Sep 3, 2020
680782e
doc: use consistent header typography
Trott Sep 3, 2020
72d03cd
doc: remove duplicate error code entry
Trott Sep 3, 2020
cdc1198
doc: fix certificate display in tls doc
Trott Sep 3, 2020
4d53385
test: make .out checks embedder-friendly
codebytere Sep 3, 2020
96ae05a
deps: V8: backport 3f071e3e7e15
Sep 3, 2020
28e89f6
doc: remove style for empty links
aduh95 Sep 3, 2020
f21d78d
src: shutdown libuv before exit()
addaleax Sep 2, 2020
5bd0e08
doc: fix incorrect URL in cli.md
Trott Sep 4, 2020
6d0d5b2
crypto: align parameter names with documentation
Trott Sep 4, 2020
83a3e3b
doc: update syntax highlighting color for accessibility
Trott Sep 5, 2020
2b445bb
tools: fix doc build targets
aduh95 Sep 4, 2020
a08e853
doc: spruce up user journey to local docs browsing
DerekNonGeneric Aug 30, 2020
577978a
tools: fix docopen target
aduh95 Sep 4, 2020
0ac7d54
doc: add deprecated badge to legacy URL methods
aduh95 Aug 26, 2020
1a9ca52
doc: add ESM examples in `module` API doc page
aduh95 Aug 22, 2020
791a85b
deps: V8: cherry-pick 6be2f6e26e8d
Sep 4, 2020
f03a4d7
doc: format exponents better
tniessen Sep 4, 2020
8044533
doc: add link to safe integer definition
tniessen Sep 4, 2020
1fdfaa5
bootstrap: correct --frozen-intrinsics override fix
guybedford Sep 3, 2020
f6b2286
doc: change stablility-2 color for accessibility
Trott Sep 4, 2020
a12d92c
crypto: fix randomInt range check
tniessen Sep 4, 2020
178a740
crypto: simplify KeyObject constructor
Trott Sep 5, 2020
bbf7b92
doc: use present tense in events.md
Trott Sep 5, 2020
ffae5f3
stream: save error in state
ronag Jun 28, 2020
4bb4007
stream: simpler and faster Readable async iterator
ronag Jun 23, 2020
ce5f587
2020-09-08, Version 14.10.0 (Current)
richardlau Sep 2, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: simplify "make use of" to "use"
PR-URL: #34861
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
Trott authored and richardlau committed Sep 1, 2020
commit aee3b8510b738cdf8f0fc494f687da86d0b3f8d9
4 changes: 2 additions & 2 deletions doc/api/addons.md
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ and load it instead.

## Native abstractions for Node.js

Each of the examples illustrated in this document make direct use of the
Each of the examples illustrated in this document directly use the
Node.js and V8 APIs for implementing addons. The V8 API can, and has, changed
dramatically from one V8 release to the next (and one major Node.js release to
the next). With each change, addons may need to be updated and recompiled in
Expand Down Expand Up @@ -495,7 +495,7 @@ The functions available and how to use them are documented in
## Addon examples

Following are some example addons intended to help developers get started. The
examples make use of the V8 APIs. Refer to the online [V8 reference][v8-docs]
examples use the V8 APIs. Refer to the online [V8 reference][v8-docs]
for help with the various V8 calls, and V8's [Embedder's Guide][] for an
explanation of several concepts used such as handles, scopes, function
templates, etc.
Expand Down
10 changes: 5 additions & 5 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ versions:
```

Thus, for an addon to remain ABI-compatible across Node.js major versions, it
must make use exclusively of N-API by restricting itself to using
must use N-API exclusively by restricting itself to using

```c
#include <node_api.h>
Expand Down Expand Up @@ -370,7 +370,7 @@ From the perspective of a native addon this means that the bindings it provides
may be called multiple times, from multiple contexts, and even concurrently from
multiple threads.

Native addons may need to allocate global state of which they make use during
Native addons may need to allocate global state which they use during
their entire life cycle such that the state must be unique to each instance of
the addon.

Expand Down Expand Up @@ -5504,7 +5504,7 @@ return status of `napi_closing` in response to a call to
should be the last API call made in conjunction with a given
`napi_threadsafe_function`, because after the call completes, there is no
guarantee that the `napi_threadsafe_function` is still allocated. For the same
reason, do not make use of a thread-safe function
reason, do not use a thread-safe function
after receiving a return value of `napi_closing` in response to a call to
`napi_call_threadsafe_function`. Data associated with the
`napi_threadsafe_function` can be freed in its `napi_finalize` callback which
Expand All @@ -5527,8 +5527,8 @@ reference count reaches zero. In particular, `napi_call_threadsafe_function()`
will return `napi_closing`, thus informing the threads that it is no longer
possible to make asynchronous calls to the thread-safe function. This can be
used as a criterion for terminating the thread. **Upon receiving a return value
of `napi_closing` from `napi_call_threadsafe_function()` a thread must make no
further use of the thread-safe function because it is no longer guaranteed to
of `napi_closing` from `napi_call_threadsafe_function()` a thread must not use
the thread-safe function anymore because it is no longer guaranteed to
be allocated.**

### Deciding whether to keep the process running
Expand Down
2 changes: 1 addition & 1 deletion doc/api/tls.md
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,7 @@ The `tls.createSecureContext()` method creates a `SecureContext` object. It is
usable as an argument to several `tls` APIs, such as [`tls.createServer()`][]
and [`server.addContext()`][], but has no public methods.

A key is *required* for ciphers that make use of certificates. Either `key` or
A key is *required* for ciphers that use certificates. Either `key` or
`pfx` can be used to provide it.

If the `ca` option is not given, then Node.js will default to using
Expand Down