Skip to content

common.mustcall() is added #34996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PoojaDurgad wants to merge 5 commits into from
Closed

common.mustcall() is added #34996

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfcad47
code:commom.mustCall() is added for the callbacks net.createServer() and
PoojaDurgad Aug 25, 2020
79a7ea6
code:syntax error cleared
PoojaDurgad Aug 25, 2020
67f1278
code: common.mustcall() modified
PoojaDurgad Aug 25, 2020
66b9109
code: common.mustcall() is added.
PoojaDurgad Aug 31, 2020
a36efab
code:remove stale changes
PoojaDurgad Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code: common.mustcall() is added.
  • Loading branch information
@PoojaDurgad
PoojaDurgad committed Aug 31, 2020
commit 66b9109bc653004e14f66171a8f0adae2a20d209
8 changes: 4 additions & 4 deletions test/parallel/test-http-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');

const http = require('http');
const Countdown = require('../common/countdown');
const MAX_COUNT = 11;

const server = http.createServer(function(req, res) {
const server = http.createServer(common.mustCall(function(req, res) {
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.end('OK');
});
}, MAX_COUNT));

const MAX_COUNT = 11;
const agent = new http.Agent({ maxSockets: 1 });
const countdown = new Countdown(MAX_COUNT, () => server.close());

Expand Down