Skip to content

http2: fix Http2Response.sendDate #34850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaolucasl wants to merge 2 commits into from
Closed

http2: fix Http2Response.sendDate #34850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1bfc8
http2: fix Http2Response.sendDate
joaolucasl Aug 20, 2020
3cb8d72
http2: simplify `options.sendDate` assertion in headers
joaolucasl Aug 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http2: simplify options.sendDate assertion in headers
  • Loading branch information
@joaolucasl
joaolucasl committed Aug 22, 2020
commit 3cb8d7221a571a0d43e7f18ebda92422427e73e0
13 changes: 6 additions & 7 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2292,13 +2292,12 @@ function processHeaders(oldHeaders, options) {
headers[HTTP2_HEADER_STATUS] =
headers[HTTP2_HEADER_STATUS] | 0 || HTTP_STATUS_OK;

let sendDate = true;
if (options.sendDate !== null && options.sendDate !== undefined)
sendDate = options.sendDate;

if (sendDate && (headers[HTTP2_HEADER_DATE] === null ||
headers[HTTP2_HEADER_DATE] === undefined))
headers[HTTP2_HEADER_DATE] = utcDate();
if (options.sendDate == null || options.sendDate) {
if (headers[HTTP2_HEADER_DATE] === null ||
headers[HTTP2_HEADER_DATE] === undefined) {
headers[HTTP2_HEADER_DATE] = utcDate();
}
}

// This is intentionally stricter than the HTTP/1 implementation, which
// allows values between 100 and 999 (inclusive) in order to allow for
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-http2-compat-serverresponse-headers-send-date.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ server.listen(0, common.mustCall(() => {
const session = http2.connect(`http://localhost:${server.address().port}`);
const req = session.request();

req.on('response', (headers, flags) => {
req.on('response', common.mustCall((headers, flags) => {
assert.strictEqual('Date' in headers, false);
assert.strictEqual('date' in headers, false);
});
}));

req.on('end', () => {
req.on('end', common.mustCall(() => {
session.close();
server.close();
});
}));
}));