Skip to content

dns: add setLocalAddress to Resolver #34824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daguej wants to merge 11 commits into from
Closed

dns: add setLocalAddress to Resolver #34824

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee54a89
dns: add setLocalAddress to Resolver
daguej Aug 18, 2020
70decaa
fix lint errors
daguej Aug 18, 2020
d0a7dab
clean up ares_set_local calls
daguej Aug 22, 2020
1344714
nits
daguej Aug 22, 2020
a8b30db
add promise resolver tests
daguej Aug 22, 2020
de1e8c5
clarify IPv4/IPv6 API
daguej Aug 27, 2020
d672863
fix lint
daguej Aug 27, 2020
ac0f189
throw errors with codes
daguej Aug 29, 2020
605d999
tweak doc language
daguej Aug 29, 2020
cbc571a
fix lint
daguej Aug 29, 2020
4b1c360
cares_get_32bit -> ReadUint32BE
daguej Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@daguej @aduh95
daguej authored and aduh95 committed Oct 24, 2020
commit d672863357871defbfae8b5d7d3d7ad634820c59
8 changes: 5 additions & 3 deletions src/cares_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2232,7 +2232,7 @@ void SetLocalAddress(const FunctionCallbackInfo<Value>& args) {
ChannelWrap* channel;
ASSIGN_OR_RETURN_UNWRAP(&channel, args.Holder());

CHECK(args.Length() == 2);
CHECK_EQ(args.Length(), 2);
CHECK(args[0]->IsString());

Isolate* isolate = args.GetIsolate();
Expand Down Expand Up @@ -2263,13 +2263,15 @@ void SetLocalAddress(const FunctionCallbackInfo<Value>& args) {

if (uv_inet_pton(AF_INET, *ip1, &addr1) == 0) {
if (type0 == 4) {
return env->ThrowError("Invalid argument. Cannot specify two IPv4 addresses.");
return env->ThrowError(
"Invalid argument. Cannot specify two IPv4 addresses.");
} else {
ares_set_local_ip4(channel->cares_channel(), cares_get_32bit(addr1));
}
} else if (uv_inet_pton(AF_INET6, *ip1, &addr1) == 0) {
if (type0 == 6) {
return env->ThrowError("Invalid argument. Cannot specify two IPv6 addresses.");
return env->ThrowError(
"Invalid argument. Cannot specify two IPv6 addresses.");
} else {
ares_set_local_ip6(channel->cares_channel(), addr1);
}
Expand Down