Skip to content

test: fix test_worker_terminate_finalization #34726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: fix test_worker_terminate_finalization #34726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix test_worker_terminate_finalization 
The test was missing an initialization of the global `ref` variable
because there was also an unused local one, leading to failures
like the one seen in #34625.
  • Loading branch information
@addaleax
addaleax committed Aug 11, 2020
commit 432f05e6b075b033e6a08b845dc9f8f9dd585596
1 change: 0 additions & 1 deletion test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ napi_value Test(napi_env env, napi_callback_info info) {
size_t argc = 1;
napi_value argv[1];
napi_value result;
napi_ref ref;
void* bufferData = malloc(BUFFER_SIZE);

NAPI_CALL(env, napi_get_cb_info(env, info, &argc, argv, NULL, NULL));
Expand Down