Skip to content

quic: multiple TODO cleanups #34655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

quic: multiple TODO cleanups #34655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c7cbef
quic: resolve minor TODO in QuicSocket
jasnell Aug 6, 2020
b82bf12
quic: resolve some minor TODOs
jasnell Aug 7, 2020
a893264
quic: limit push check to http/3
jasnell Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: resolve some minor TODOs
  • Loading branch information
@jasnell
jasnell committed Aug 11, 2020
commit b82bf12cd2db41988ba2b35f3a762741291a9886
2 changes: 0 additions & 2 deletions lib/internal/quic/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,6 @@ function createSecureContext(options, init_cb) {
const sc_options = validateCreateSecureContextOptions(options);
const { groups, earlyData } = sc_options;
const sc = _createSecureContext(sc_options);
// TODO(@jasnell): Determine if it's really necessary to pass in groups here.
init_cb(sc.context, groups, earlyData);
return sc;
}
Expand Down Expand Up @@ -2702,7 +2701,6 @@ class QuicStream extends Duplex {
}

[kInspect](depth, options) {
// TODO(@jasnell): Proper custom inspect implementation
const direction = this.bidirectional ? 'bidirectional' : 'unidirectional';
const initiated = this.serverInitiated ? 'server' : 'client';
return customInspect(this, {
Expand Down
9 changes: 5 additions & 4 deletions src/quic/node_quic_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3378,8 +3378,10 @@ int QuicSession::OnStreamReset(
// sensitivity of PATH_CHALLENGE operations (an attacker
// could use a compromised PATH_CHALLENGE to trick an endpoint
// into redirecting traffic).
// TODO(@jasnell): In the future, we'll want to explore whether
// we want to handle the different cases of ngtcp2_rand_ctx
//
// The ngtcp2_rand_ctx tells us what the random data is used for.
// Currently, there is only one use. In the future, we'll want to
// explore whether we want to handle the different cases uses.
int QuicSession::OnRand(
ngtcp2_conn* conn,
uint8_t* dest,
Expand Down Expand Up @@ -3744,8 +3746,7 @@ void QuicSessionSilentClose(const FunctionCallbackInfo<Value>& args) {
session->Close(QuicSessionListener::SESSION_CLOSE_FLAG_SILENT);
}

// TODO(addaleax): This is a temporary solution for testing and should be
// removed later.
// This is used purely for testing.
void QuicSessionRemoveFromSocket(const FunctionCallbackInfo<Value>& args) {
QuicSession* session;
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
Expand Down