Skip to content

src: set SA_SIGINFO flag when using sa_sigaction #34648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 2 commits into from
Closed

src: set SA_SIGINFO flag when using sa_sigaction #34648

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
517a93d
src: set SA_SIGINFO flag when using sa_sigaction
richardlau Aug 6, 2020
f594659
fixup! src: set SA_SIGINFO flag when using sa_sigaction
richardlau Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: set SA_SIGINFO flag when using sa_sigaction 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@richardlau @jasnell
richardlau and jasnell authored Aug 6, 2020
commit f594659350e31c7a882fdc23f5233a12d5355cbe
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ void RegisterSignalHandler(int signal,
struct sigaction sa;
memset(&sa, 0, sizeof(sa));
sa.sa_sigaction = handler;
sa.sa_flags = reset_handler ? SA_RESETHAND | SA_SIGINFO : SA_SIGINFO;
sa.sa_flags = SA_SIGINFO | (reset_handler ? SA_RESETHAND : 0);
sigfillset(&sa.sa_mask);
CHECK_EQ(sigaction(signal, &sa, nullptr), 0);
}
Expand Down