Skip to content

fs: fix when path is buffer #34540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
himself65 wants to merge 3 commits into from
Closed

fs: fix when path is buffer #34540

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0133a8
fs: fix when path is buffer
himself65 Jul 28, 2020
0547fc8
fixup!
himself65 Jul 28, 2020
af685bd
fixup!
himself65 Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup!
  • Loading branch information
@himself65
himself65 committed Jul 28, 2020
commit 0547fc8fc8ce4af2615c2801134e144c43492c8c
1 change: 1 addition & 0 deletions test/parallel/test-fs-symlink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ fs.symlink(linkData, linkPath, common.mustCall(function(err) {
}));
}));

tmpdir.refresh();
// Fixes: https://github.com/nodejs/node/issues/34514
fs.symlinkSync(Buffer.from(linkData), linkPath);

Expand Down