Skip to content

src: skip weak references for memory tracking #34469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: skip weak references for memory tracking #34469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: skip weak references for memory tracking 
The memory tracking is supposed to represent the “keeps-alive”
relations between objects for a heap dump, in order to enable
developers to figure out which objects keep which other objects
on the heap.

Weak references do not participate in that relation. Therefore,
we should not be tracking them.
  • Loading branch information
@addaleax
addaleax committed Jul 21, 2020
commit 9908765a30c9d93184237aa5497207700e854538
3 changes: 2 additions & 1 deletion src/memory_tracker-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ template <typename T, bool kIsWeak>
void MemoryTracker::TrackField(const char* edge_name,
const BaseObjectPtrImpl<T, kIsWeak>& value,
const char* node_name) {
if (value.get() == nullptr) return;
if (value.get() == nullptr || kIsWeak) return;
TrackField(edge_name, value.get(), node_name);
}

Expand Down Expand Up @@ -214,6 +214,7 @@ template <typename T>
void MemoryTracker::TrackField(const char* edge_name,
const v8::PersistentBase<T>& value,
const char* node_name) {
if (value.IsWeak()) return;
TrackField(edge_name, value.Get(isolate_));
}

Expand Down