Skip to content

tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order #34444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masx200 wants to merge 7 commits into from
Closed

tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order #34444

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a9e2e5
Update _tls_wrap.js
masx200 Jul 20, 2020
16e2520
Update _tls_wrap.js
masx200 Jul 20, 2020
206a724
https://github.com/nodejs/node/issues/34110
masx200 Jul 20, 2020
b75bdd3
Update _tls_wrap.js
masx200 Jul 20, 2020
dfd9a31
Update lib/_tls_wrap.js
masx200 Jul 20, 2020
5549fd2
Update lib/_tls_wrap.js
masx200 Jul 20, 2020
9d17cb9
Update lib/_tls_wrap.js
masx200 Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/_tls_wrap.js 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@masx200 @jasnell
masx200 and jasnell authored Jul 20, 2020
commit 5549fd26ef7de87d29581a93861b07de2f89f50c
3 changes: 1 addition & 2 deletions lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,8 +1412,7 @@ Server.prototype.addContext = function(servername, context) {
if (!servername) {
throw new ERR_TLS_REQUIRED_SERVER_NAME();
}
//https://github.com/nodejs/node/issues/34110
servername=servername.toLowerCase()
servername = servername.toLowerCase()

const re = new RegExp('^' +
servername.replace(/([.^$+?\-\\[\]{}])/g, '\\$1')
Expand Down