Skip to content

repl: give repl entries unique names. fixes #33233 #34372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 6 commits into from
Closed

repl: give repl entries unique names. fixes #33233 #34372

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8aef370
repl: give repl entries unique names.
bmeck Jul 14, 2020
8434975
fix tests
bmeck Jul 15, 2020
f24f521
Update lib/repl.js
bmeck Jul 15, 2020
b116249
linter...
bmeck Jul 15, 2020
b40623f
Update test/parallel/test-repl-dynamic-import.js
bmeck Jul 29, 2020
98ffe4a
lint
bmeck Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/repl.js
  • Loading branch information
@bmeck
bmeck authored Jul 15, 2020
commit f24f521a2a0da5e7a2078be3a685038beed036b6
2 changes: 2 additions & 0 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ const {

const history = require('internal/repl/history');
let nextREPLResourceNumber = 1;
// this prevents v8 code cache from getting confused and using a different
Comment thread
bmeck marked this conversation as resolved.
Resolved
// cache from a resource of the same name
function getREPLResourceName() {
Comment thread
bmeck marked this conversation as resolved.
Resolved
return `REPL${nextREPLResourceNumber++}`;
}
Expand Down