Skip to content

test: fix flaky test-http2-reset-flood #34318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: fix flaky test-http2-reset-flood #34318

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e95a46
test: fix flaky test-http2-reset-flood
Trott Jul 12, 2020
a2457fe
fixup! test: fix flaky test-http2-reset-flood
Trott Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: fix flaky test-http2-reset-flood 
Set `allowHalfOpen: true` in the client.

Fixes: #29802
Refs: #31806
  • Loading branch information
@Trott
Trott committed Jul 12, 2020
commit 9e95a46aaa5838e33a916fd3ccc88a902dcc9019
2 changes: 1 addition & 1 deletion test/parallel/test-http2-reset-flood.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) {
process.env.HAS_STARTED_WORKER = 1;
const worker = new Worker(__filename).on('message', common.mustCall((port) => {
const h2header = Buffer.alloc(9);
const conn = net.connect(port);
const conn = net.connect({ port, allowHalfOpen: true });

conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n');

Expand Down