Skip to content

Fix flaky test-child-process-emfile #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 5 commits into from
Closed

Fix flaky test-child-process-emfile #3430

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
421b571
test: fix flaky test-child-process-emfile
Trott Oct 18, 2015
30edd30
fixup
Trott Oct 19, 2015
5556196
fixup: handle `unlimited` being coerced to NaN
Trott Oct 20, 2015
1a6d2e6
fixup: set with -n, check with -Hn
Trott Oct 20, 2015
5f5bb36
fixup: add quotes around paths
Trott Oct 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: handle unlimited being coerced to NaN
  • Loading branch information
@Trott
Trott committed Oct 20, 2015
commit 55561960833070ada7377efd7afcdd3fbfa46deb
2 changes: 1 addition & 1 deletion test/sequential/test-child-process-emfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (common.isWindows) {
}

const ulimit = Number(child_process.execSync('ulimit -n'));
if (ulimit > 64) {
if (ulimit > 64 || Number.isNaN(ulimit)) {
// Sorry about this nonsense. It can be replaced if
// https://github.com/nodejs/node-v0.x-archive/pull/2143#issuecomment-2847886
// ever happens.
Expand Down