Skip to content

child_process: allow promisified exec to be cancel #34249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metcoder95 wants to merge 25 commits into from
Closed

child_process: allow promisified exec to be cancel #34249

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
eed3f17
child_process: allow promisified exec to be cancel
Jul 7, 2020
0ef841d
child_process: fix validation issue
Jul 13, 2020
70cb86c
child_process: use Primordials instead of plain Promise
Oct 23, 2020
a6ae623
child_process: refactor according to review
Oct 23, 2020
988ea3f
child_process: remove license from test
Oct 23, 2020
78e7521
child_process: improve testing
Oct 23, 2020
c8210f6
child_process: fix linter issues
Oct 23, 2020
3dca212
child_process: check if AbortSignal is aborted before rejecting/resol…
Oct 28, 2020
4163c44
child_process: check for signal before looking is aborted
Oct 28, 2020
9e3291e
child_process: refactor signal to use spawn function
Dec 22, 2020
3b14ebe
child_process: fix linter issues
Dec 22, 2020
087f924
child_process: revert check for extra callback
Dec 30, 2020
0fd0719
child_process: fix double AbortError emit
Dec 30, 2020
a41ac9a
child_process: fix linter issues
Dec 30, 2020
f9af3fd
child_process: fix fork issue with AbortController
Jan 12, 2021
2b19cd5
child_process: remove whitespace
Jan 12, 2021
f642015
child_process: re-order alphabetically the options
Jan 14, 2021
dade71b
child_process: refactor spawnWithSignal
Jan 18, 2021
5e7aa7d
child_process: remove wrapper function
Jan 18, 2021
2305734
child_process: revert refactor to spawn
Jan 18, 2021
a60b935
child_process: fix tests
Jan 18, 2021
fe077b0
child_process: refactor
Jan 21, 2021
72ff68a
child_process: refactor tests
Jan 21, 2021
026021a
child_process: refactor listeners args
Jan 21, 2021
c093035
child_process: inline listener
Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
child_process: inline listener
  • Loading branch information
Carlos Fuentes
Carlos Fuentes committed Jan 21, 2021
commit c0930354228f1e14be1c1a5a1e400c913e7f3970
5 changes: 1 addition & 4 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,10 +608,7 @@ function spawn(file, args, options) {
} else {
signal.addEventListener('abort', onAbortListener, { once: true });
child.once('close',
() =>
signal
.removeEventListener('abort', onAbortListener)
);
() => signal.removeEventListener('abort', onAbortListener));
}

function onAbortListener() {
Expand Down