Skip to content

test: fix flaky test for symlinks #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

test: fix flaky test for symlinks #3418

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
193c6b2
test: fix flaky test for symlinks
Trott Oct 17, 2015
2475e1b
fixup
Trott Oct 18, 2015
5e12a31
fixup
Trott Oct 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@Trott
Trott committed Oct 18, 2015
commit 5e12a3180d25590ef4cb9fc259e376d4f34dac27
50 changes: 50 additions & 0 deletions test/parallel/test-fs-symlink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');
const exec = require('child_process').exec;

var linkTime;
var fileTime;

if (common.isWindows) {
// On Windows, creating symlinks requires admin privileges.
// We'll only try to run symlink test if we have enough privileges.
exec('whoami /priv', function(err, o) {
if (err || o.indexOf('SeCreateSymbolicLinkPrivilege') == -1) {
console.log('1..0 # Skipped: insufficient privileges');
return;
}
});
}

common.refreshTmpDir();

// test creating and reading symbolic link
const linkData = path.join(common.fixturesDir, '/cycles/root.js');
const linkPath = path.join(common.tmpDir, 'symlink1.js');

fs.symlink(linkData, linkPath, function(err) {
if (err) throw err;

fs.lstat(linkPath, common.mustCall(function(err, stats) {
if (err) throw err;
linkTime = stats.mtime.getTime();
}));

fs.stat(linkPath, common.mustCall(function(err, stats) {
if (err) throw err;
fileTime = stats.mtime.getTime();
}));

fs.readlink(linkPath, common.mustCall(function(err, destination) {
if (err) throw err;
assert.equal(destination, linkData);
}));
});


process.on('exit', function() {
assert.notStrictEqual(linkTime, fileTime);
});