Skip to content

esm: Modify getFormat and getSource loader hooks #34144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julian-londono wants to merge 8 commits into from
Closed

esm: Modify getFormat and getSource loader hooks #34144

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6aee088
Add initial formatting change
Jun 30, 2020
fb154be
Add error-handling wrapper for getSource
Jun 30, 2020
0fc1e6b
Fix test-esm-loader-invalid-format
Jul 17, 2020
9478e97
esm_display_syntax_error_module
Jul 17, 2020
2440daa
Fix getSource validation
Jul 18, 2020
fa3a711
Fix getSource return object
Jul 20, 2020
8e90771
Change syntax
Jul 20, 2020
1b2330a
Fix lint-js errors
Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test-esm-loader-invalid-format
  • Loading branch information
Julian Londono
Julian Londono committed Jul 17, 2020
commit 0fc1e6b7a3a6f89f59c45b5caf9c22ed3cd546c8
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ class Loader {
const url = await this.resolve(specifier, parentURL);
let format = await this.getFormat(url);
let source;
if(format !== "builtin" && format !== "commonjs"){
if(format !== "builtin" && format !== "commonjs" && translators.get(format)){
const sourceObj = await this.getSource(url, format);
({ source } = sourceObj);
format = sourceObj.format? sourceObj.format : format;
Expand Down