Skip to content

events: combined event target fixes #34015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 11 commits into from
Closed

events: combined event target fixes #34015

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
343bcf7
events: use internal/validators in event_target.js
lundibundi May 30, 2020
8a220fc
events: fix depth in customInspectSymbol and clean up
lundibundi May 30, 2020
fea2394
events: fix EventTarget support
benjamingr May 30, 2020
5d34ea0
events: Handle a range of this values for dispatchEvent
Zirak May 30, 2020
df1a006
events: expose Event statics
benjamingr May 29, 2020
5893b88
events: support event handlers
benjamingr May 29, 2020
2c7b2b6
event: cancelBubble is a property
benjamingr May 28, 2020
d900f87
events: add event-target tests
jasnell Jun 22, 2020
dbddf3c
events: support dispatching event from event
jasnell Jun 22, 2020
227258b
events: improve argument handling, start passive
jasnell Jun 22, 2020
65af6f1
benchmark: fix EventTarget benchmark
mscdex Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
events: fix depth in customInspectSymbol and clean up
  • Loading branch information
@lundibundi @jasnell
lundibundi authored and jasnell committed Jun 21, 2020
commit 8a220fc7ea02b0be4bb89efd1b02994250cb69e0
19 changes: 8 additions & 11 deletions lib/internal/event_target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

const {
ArrayFrom,
Boolean,
Error,
Map,
NumberIsInteger,
Object,
Set,
Symbol,
Expand Down Expand Up @@ -78,7 +80,7 @@ class Event {
return name;

const opts = Object.assign({}, options, {
dept: options.depth === null ? null : options.depth - 1
depth: NumberIsInteger(options.depth) ? options.depth - 1 : options.depth
});

return `${name} ${inspect({
Expand Down Expand Up @@ -294,7 +296,7 @@ class EventTarget {
this.#emitting.delete(event.type);
event[kTarget] = undefined;

return event.defaultPrevented === true ? false : true;
return event.defaultPrevented !== true;
}

[customInspectSymbol](depth, options) {
Expand All @@ -303,7 +305,7 @@ class EventTarget {
return name;

const opts = Object.assign({}, options, {
dept: options.depth === null ? null : options.depth - 1
depth: NumberIsInteger(options.depth) ? options.depth - 1 : options.depth
});

return `${name} ${inspect({}, opts)}`;
Expand Down Expand Up @@ -429,15 +431,10 @@ function validateEventListenerOptions(options) {
if (typeof options === 'boolean')
return { capture: options };
validateObject(options, 'options');
const {
once = false,
capture = false,
passive = false,
} = options;
return {
once: !!once,
capture: !!capture,
passive: !!passive,
once: Boolean(options.once),
capture: Boolean(options.capture),
passive: Boolean(options.passive),
};
}

Expand Down