Skip to content

lib,src: remove cpu profiler idle notifier #34010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 2 commits into from
Closed

lib,src: remove cpu profiler idle notifier #34010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61468b8
lib,src: remove cpu profiler idle notifier
bnoordhuis Jun 22, 2020
49951ae
squash! add comment
bnoordhuis Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! add comment
  • Loading branch information
@bnoordhuis
bnoordhuis committed Jun 23, 2020
commit 49951aefcbd9d958e4095843832e2dfbda7e7ad5
4 changes: 4 additions & 0 deletions lib/internal/bootstrap/switches/is_main_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const rawMethods = internalBinding('process_methods');
// TODO(joyeecheung): deprecate and remove these underscore methods
process._debugProcess = rawMethods._debugProcess;
process._debugEnd = rawMethods._debugEnd;

// See the discussion in https://github.com/nodejs/node/issues/19009 and
// https://github.com/nodejs/node/pull/34010 for why these are no-ops.
// Five word summary: they were broken beyond repair.
process._startProfilerIdleNotifier = () => {};
Comment thread
bnoordhuis marked this conversation as resolved.
process._stopProfilerIdleNotifier = () => {};

@bnoordhuis bnoordhuis Jun 22, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax @BridgeAR I turned them into no-ops like #33138 does. I feel less strongly than Anna about emitting warnings but I also don't really see the point because the functionality has been broken-ish for a long time. Doing nothing is more correct than doing the wrong thing, IMO. :-)


Expand Down