Skip to content

timers: introduce timers/promises #33950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
+250 −127
Closed

timers: introduce timers/promises #33950

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78edbf6
timers: introduce timers/promises
jasnell Jun 18, 2020
5bb0cb4
fixup! timers: introduce timers/promises
jasnell Jun 22, 2020
c17288d
fixup! fixup! timers: introduce timers/promises
jasnell Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! timers: introduce timers/promises
  • Loading branch information
@jasnell
jasnell committed Jun 22, 2020
commit c17288d7138f0978ed55106fba7df6a7acf9a2cf
12 changes: 6 additions & 6 deletions test/parallel/test-timers-promisified.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ process.on('multipleResolves', common.mustNotCall());
}

{
exec(`${process.execPath} -pe 'const assert = require("assert");` +
'require("timers/promises").setTimeout(1000, null, { ref: false }).' +
'then(assert.fail)\'').then(common.mustCall(({ stderr }) => {
exec(`${process.execPath} -pe "const assert = require('assert');` +
'require(\'timers/promises\').setTimeout(1000, null, { ref: false }).' +
'then(assert.fail)"').then(common.mustCall(({ stderr }) => {
assert.strictEqual(stderr, '');
}));
}

{
exec(`${process.execPath} -pe 'const assert = require("assert");` +
'require("timers/promises").setImmediate(null, { ref: false }).' +
'then(assert.fail)\'').then(common.mustCall(({ stderr }) => {
exec(`${process.execPath} -pe "const assert = require('assert');` +
'require(\'timers/promises\').setImmediate(null, { ref: false }).' +
'then(assert.fail)"').then(common.mustCall(({ stderr }) => {
assert.strictEqual(stderr, '');
}));
}