Skip to content

Fix an assertion failure at exit in the macOS app sandbox #33944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wan9chi wants to merge 5 commits into from
Closed

Fix an assertion failure at exit in the macOS app sandbox #33944

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
317621b
src: tolerate EPERM returned from tcsetattr
wan9chi Jun 18, 2020
5f4f969
test: add test for running in macOS app sandbox
wan9chi Jun 18, 2020
3cb770e
test: use process.execPath to get path of testing node
wan9chi Jun 18, 2020
d939f7f
test: log codesign result (ci debug)
wan9chi Jun 19, 2020
59e434d
Revert "test: log codesign result (ci debug)"
wan9chi Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: tolerate EPERM returned from tcsetattr 
macOS app sandbox makes tcsetattr return EPERM. The CHECK_EQ(0, err) here would fail when a sandboxed Node.js process is exiting. This commit fixes this issue.
  • Loading branch information
@wan9chi
wan9chi committed Jun 18, 2020
commit 317621b4a12562eb75055a67bb2c5556f53fe017
5 changes: 4 additions & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,10 @@ void ResetStdio() {
err = tcsetattr(fd, TCSANOW, &s.termios);
while (err == -1 && errno == EINTR); // NOLINT
CHECK_EQ(0, pthread_sigmask(SIG_UNBLOCK, &sa, nullptr));
CHECK_EQ(0, err);

// Normally we expect err == 0. But if macOS App Sandbox is enabled,
// tcsetattr will fail with err == -1 and errno == EPERM.
CHECK_IMPLIES(err != 0, err == -1 && errno == EPERM);
}
}
#endif // __POSIX__
Expand Down