Skip to content

src: allow setting a dir for all diagnostic output #33584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshCripps wants to merge 4 commits into from
Closed

src: allow setting a dir for all diagnostic output #33584

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c763920
src: allow setting a dir for all diagnostic output
May 27, 2020
6d40876
src: add cpu-prof and heap-prof to diagnostic-dir
May 28, 2020
57e0028
src: add testing for --diagnostic-dir option
Jun 2, 2020
900e397
src: correct diagnostic-dir doc links
Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: correct diagnostic-dir doc links
  • Loading branch information
AshCripps AshCripps
AshCripps authored and AshCripps committed Jul 14, 2020
commit 900e3973962b90b532f2edc05ba29765a0b24b01
12 changes: 6 additions & 6 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Specify the directory where the CPU profiles generated by `--cpu-prof` will
be placed.

The default value is controlled by the
[--diagnostic-dir](#--diagnostic-dir=directory) command line option.
[--diagnostic-dir](#cli_diagnostic_dir_directory) command line option.

### `--cpu-prof-interval`
<!-- YAML
Expand All @@ -136,9 +136,9 @@ Set the directory to which all diagnostic output files will be written to.
Defaults to current working directory.

Affects the default output directory of:
* [--cpu-prof-dir](#--cpu-prof-dir)
* [--heap-prof-dir](#--heap-prof-dir)
* [--redirect-warnings](#--redirect-warnings=file)
* [--cpu-prof-dir](#cli_cpu_prof_dir)
* [--heap-prof-dir](#cli_heap_prof_dir)
* [--redirect-warnings](#cli_redirect_warnings_file)

### `--disable-proto=mode`
<!-- YAML
Expand Down Expand Up @@ -374,7 +374,7 @@ Specify the directory where the heap profiles generated by `--heap-prof` will
be placed.

The default value is controlled by the
[--diagnostic-dir](#--diagnostic-dir=directory) command line option.
[--diagnostic-dir](#cli_diagnostic_dir_directory) command line option.

### `--heap-prof-interval`
<!-- YAML
Expand Down Expand Up @@ -658,7 +658,7 @@ warning will be written to stderr instead.

The `file` name may be an absolute path. If it is not, the default directory it
will be written to is controlled by the
[--diagnostic-dir](#--diagnostic-dir=directory) command line option.
[--diagnostic-dir](#cli_diagnostic_dir_directory) command line option.

### `--report-compact`
<!-- YAML
Expand Down
2 changes: 1 addition & 1 deletion src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ DebugOptionsParser::DebugOptionsParser() {
}

EnvironmentOptionsParser::EnvironmentOptionsParser() {
AddOption("--diagnostic-dir",
AddOption("--diagnostic-dir",
"set dir for all output files"
" (default: current working directory)",
&EnvironmentOptions::diagnostic_dir,
Expand Down