Skip to content

[v12.x] Disable headers timeout #33307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShogunPanda wants to merge 4 commits into from
Closed

[v12.x] Disable headers timeout #33307

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87e26dc
http: disable headersTimeout check when set to zero
ShogunPanda Apr 29, 2020
563692b
doc: updated headersTimeout documentation
ShogunPanda Apr 29, 2020
2eb7c2e
lint: fix failures
ShogunPanda May 8, 2020
31cfa4d
test: add test for disabled headersTimeout
ShogunPanda May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: fix failures
  • Loading branch information
@ShogunPanda
ShogunPanda committed May 8, 2020
commit 2eb7c2e1a2aa185cf1f68a6b5c7891baf577c354
8 changes: 6 additions & 2 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,12 @@ function onParserExecute(server, socket, parser, state, ret) {

// If we have not parsed the headers, destroy the socket
// after server.headersTimeout to protect from DoS attacks.
// start === 0 means that we have parsed headers.
if (start !== 0 && server.headersTimeout && nowDate() - start > server.headersTimeout) {
// start === 0 means that we have parsed headers, while
// server.headersTimeout === 0 means user disabled this check.
if (
start !== 0 && server.headersTimeout &&
nowDate() - start > server.headersTimeout
) {
const serverTimeout = server.emit('timeout', socket);

if (!serverTimeout)
Expand Down